NSRDB resource is called with mode in some nsrdb tests. Adding this…
#146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to AbstractInterpolatedResource.__init__
grantbuster
requested changes
Feb 16, 2023
Sure. Is that preferred to matching the BaseResource signature? |
|
Yes, please update the base resource signature too. |
grantbuster
approved these changes
Feb 16, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Feb 16, 2023
NSRDB resource is called with `mode` in some nsrdb tests. Adding this…
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to AbstractInterpolatedResource.init