Restore support for passing device in CPU-only environment
#107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edknv
approved these changes
Feb 28, 2023
oliverholworthy
added a commit
that referenced
this pull request
Mar 13, 2023
Add test for passing device to check this works on CPU
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last PR #104 changed the way the array lib was configured based on the device configured. This assumed that the device would always be set to
"cpu"in a CPU-only environment (where cupy was not installed).This PR updates the logic setting the
deviceattribute of the loader so that it's always set to"cpu"if there is no GPU available or if the dataset is on CPU.