Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change row lengths unit tests to use cpu and single gpu #115

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

edknv
Copy link
Contributor

@edknv edknv commented Mar 23, 2023

Follow-up to #113.

This updates test_row_lengths_to_offsets_device to only test cpu <-> cuda:0 and removes the cpu <-> cuda:1 case because the test will fail if we only have a single GPU. We simply remove the second gpu case because testing the cpu <-> cuda:0 case should be sufficient for testing if the tensor concatenation works across devices.

@edknv edknv added bug Something isn't working ci chore labels Mar 23, 2023
@edknv edknv added this to the Merlin 23.03 milestone Mar 23, 2023
@edknv edknv self-assigned this Mar 23, 2023
@edknv edknv merged commit 11776e6 into NVIDIA-Merlin:main Mar 23, 2023
@edknv edknv deleted the torch/fix-row-lengths-test branch March 23, 2023 18:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working chore ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants