Array loaderbase merge #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlhigley
reviewed
Apr 3, 2023
| @@ -528,26 +589,6 @@ def _process_batch(self, tensors): | |||
|
|
|||
| return X, labels | |||
|
|
|||
| def _pack(self, gdf): | |||
There was a problem hiding this comment.
It looks like this is still used in the JAX dataloader
karlhigley
approved these changes
Apr 3, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the array loader into the LoaderBase class. There is no need to have two different classes as all inheritance derives from one set of base logic (array based dataloading) so now we can merge the array and loader base.