Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Set device for torch tensors with gpu > 1 #132

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Set device for torch tensors with gpu > 1 #132

merged 2 commits into from
Apr 12, 2023

Conversation

edknv
Copy link
Contributor

@edknv edknv commented Apr 12, 2023

Fixes #131.

@edknv edknv self-assigned this Apr 12, 2023
@edknv edknv added the bug Something isn't working label Apr 12, 2023
@edknv edknv added this to the Merlin 23.04 milestone Apr 12, 2023
@edknv edknv marked this pull request as ready for review April 12, 2023 15:59
oliverholworthy
oliverholworthy approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@oliverholworthy oliverholworthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to write a test for this? which might require the 2GPU runner to work?

@edknv
Copy link
Contributor Author

edknv commented Apr 12, 2023

Would it be possible to write a test for this? which might require the 2GPU runner to work?

Yes, we have to use the 2GPU runner and also use process launchers like torchrun or torchx so it's a bit involved. I'll add tests as a separate PR.

@rnyak rnyak mentioned this pull request Apr 12, 2023
Closed
@edknv edknv merged commit 8782c9d into NVIDIA-Merlin:main Apr 12, 2023
@edknv edknv deleted the fix_torch_multi_gpu branch April 12, 2023 16:26
edknv added a commit to edknv/dataloader that referenced this pull request Apr 13, 2023
@edknv
Revert "Set device for torch tensors with gpu > 1 (NVIDIA-Merlin#132)"
525f009 
This reverts commit 8782c9d.
@edknv edknv mentioned this pull request Apr 13, 2023
Open
edknv added a commit that referenced this pull request Apr 14, 2023
@edknv
Revert "Set device for torch tensors with gpu > 1 (#132)" (#134)
014b658 
This reverts commit 8782c9d.
@edknv edknv mentioned this pull request Apr 17, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@oliverholworthy oliverholworthy oliverholworthy approved these changes

@jperez999 jperez999 Awaiting requested review from jperez999

@karlhigley karlhigley Awaiting requested review from karlhigley

Assignees

@edknv edknv

Labels
bug Something isn't working
Projects
None yet
Milestone
Merlin 23.04
Development

Successfully merging this pull request may close these issues.

Device assignment does not work in PyTorch
2 participants
@edknv @oliverholworthy