clear init to ensure loading of framework specific ops only #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlhigley
approved these changes
Nov 15, 2022
Documentation preview |
jperez999
added a commit
that referenced
this pull request
Nov 16, 2022
remove embedding ops from init to ensure loading of only available framework ops
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the imports from the init. Allowing for clean imports when you only have a specific framework and not all (both) in your environment. Now you have to specifically use the import of the file containing the embeddings for the targeted framework. Ensures we dont hit import errors for frameworks that are not installed.