Add lint workflow using pre-commit #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-self-use has been removed and moved to an optional extension. https://pylint.pycqa.org/en/latest/whatsnew/2/2.14/summary.html#removed-checkers
Documentation preview |
benfred
approved these changes
Nov 22, 2022
| @@ -19,7 +19,7 @@ repos: | |||
| rev: v2.14.1 | |||
| hooks: | |||
| - id: pylint | |||
| - repo: https://gitlab.com/pycqa/flake8 | |||
| - repo: https://github.com/pycqa/flake8 | |||
There was a problem hiding this comment.
nice catch - I wonder how the gitlab url got in there (it doesn't even resolve for me?)
7 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ensure lint checks running locally with pre-commit are consistent with checks in CI.
Using pre-commit for checks in CI and running on all files, we can ensure that the versions checked locally and in CI are the same.
Details
Add lint workflow using pre-commit