-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[ASR] Online Speaker Diarization with ASR: Part-1 #7896
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Taejin Park <tango4j@gmail.com>
Signed-off-by: Taejin Park <tango4j@gmail.com>
Signed-off-by: Taejin Park <tango4j@gmail.com>
Signed-off-by: Taejin Park <tango4j@gmail.com>
Signed-off-by: Taejin Park <tango4j@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR addresses utility functions (not core functions) for online diarization with ASR (multi-speaker ASR).
Streaming ASR and diarization utility functions and classes are added with unit tests.
This is Part1 of the clustering online diarization integration.
In Part2, example file, yaml file and tutorial notebook will be uploaded.
Collection: ASR
Changelog
nemo/collections/asr/models/__init__.py
Adding
OnlineClusteringDiarizer
classnemo/collections/asr/parts/utils/decoder_timestamps_utils.py
adding
FrameBatchASRLogitsSample
andFrameBatchASRLogits
for ASR with timestamp generation
nemo/collections/asr/parts/utils/diarization_utils.py
OnlineDiarWithASR
and a few utility functionsnemo/collections/asr/parts/utils/streaming_utils.py
Adding
FrameBatchVAD
class which handles VAD streaming.Usage
Usage will be included in part2 with example file and yaml file.
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in NeMo ASR.
Additional Information
N.A.