Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ASR] Online Speaker Diarization with ASR: Part-1 #7896

Closed
wants to merge 10 commits into from

Conversation

tango4j
Copy link
Collaborator

@tango4j tango4j commented Nov 15, 2023

What does this PR do ?

This PR addresses utility functions (not core functions) for online diarization with ASR (multi-speaker ASR).
Streaming ASR and diarization utility functions and classes are added with unit tests.

This is Part1 of the clustering online diarization integration.
In Part2, example file, yaml file and tutorial notebook will be uploaded.

Collection: ASR

Changelog

nemo/collections/asr/models/__init__.py
Adding OnlineClusteringDiarizer class

nemo/collections/asr/parts/utils/decoder_timestamps_utils.py
adding FrameBatchASRLogitsSample and FrameBatchASRLogits
for ASR with timestamp generation

nemo/collections/asr/parts/utils/diarization_utils.py
OnlineDiarWithASR and a few utility functions

nemo/collections/asr/parts/utils/streaming_utils.py
Adding FrameBatchVAD class which handles VAD streaming.

Usage

Usage will be included in part2 with example file and yaml file.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • [] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  • [] Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in NeMo ASR.

Additional Information

N.A.

Signed-off-by: Taejin Park <tango4j@gmail.com>
Signed-off-by: Taejin Park <tango4j@gmail.com>
Signed-off-by: Taejin Park <tango4j@gmail.com>
Signed-off-by: Taejin Park <tango4j@gmail.com>
Signed-off-by: Taejin Park <tango4j@gmail.com>
@github-actions github-actions bot added the ASR label Nov 15, 2023
@tango4j tango4j changed the title Online diar part1 [ASR] Online diarization with ASR Part-1 Nov 16, 2023
@tango4j tango4j self-assigned this Nov 16, 2023
@tango4j tango4j requested review from jbalam-nv and fayejf November 16, 2023 00:02
@tango4j tango4j changed the title [ASR] Online diarization with ASR Part-1 [ASR] Online Speaker Diarization with ASR: Part-1 Nov 16, 2023
Copy link
Contributor

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link
Contributor

github-actions bot commented Dec 2, 2023

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Dec 2, 2023
@tango4j tango4j marked this pull request as ready for review December 6, 2023 17:55
@tango4j tango4j marked this pull request as draft December 6, 2023 17:55
@tango4j tango4j closed this Dec 6, 2023
@tango4j tango4j deleted the online_diar_part1 branch December 6, 2023 21:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant