[DetectNetTransformation] Use bicubic interpolation #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -81,7 +81,7 @@ void DetectNetTransformationLayer<Dtype>::retrieveMeanImage(Size dimensions) { | |||
|
|
|||
| // resize, if dimensions were defined: | |||
| if (dimensions.area() > 0) { | |||
| resize(data_mean_, data_mean_, dimensions, cv::INTER_CUBIC); | |||
| resize(data_mean_, data_mean_, dimensions); | |||
There was a problem hiding this comment.
don't you want to use bicubic interpolation here too?
There was a problem hiding this comment.
I was thinking it doesn't matter much because the mean image size will almost always match the incoming data size. But you're right - I might as well follow what @drendleman had originally intended.
lukeyeager
force-pushed
the
nvidia/detectnet-resize-method
branch
2 times, most recently
from
0a1c9f5 to
d4b1a0c
Compare
|
I removed the clamping.
|
lukeyeager
force-pushed
the
nvidia/detectnet-resize-method
branch
from
d4b1a0c to
867b062
Compare
mathmanu
pushed a commit
to mathmanu/caffe-jacinto
that referenced
this pull request
Jun 8, 2017
…-method [DetectNetTransformation] Use bicubic interpolation
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cv::resize()was being called withINTER_CUBICin the wrong place:http://docs.opencv.org/2.4/modules/imgproc/doc/geometric_transformations.html#resize
Before this fix
After
