Compatibility with jit.script and torch.compile: COMPLETE #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mario Geiger <mgeiger@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
|
Note: depends on backend MR #74. |
mariogeiger
reviewed
Dec 4, 2024
cuequivariance_torch/cuequivariance_torch/primitives/tensor_product.py
Outdated
Show resolved
Hide resolved
cuequivariance_torch/cuequivariance_torch/primitives/symmetric_tensor_product.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
…t-script Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
mariogeiger
approved these changes
Dec 9, 2024
cuequivariance_torch/tests/primitives/equivariant_tensor_product_test.py
Show resolved
Hide resolved
Comment on lines
-33
to
+35
| @pytest.mark.parametrize("batch", [0, 32]) | ||
| @pytest.mark.parametrize("batch", [1, 32]) |
There was a problem hiding this comment.
We must not forget to add back this test batch=0 when the backend properly supports it
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.