Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Removing tensor lists from all APIs #61

Merged
merged 7 commits into from
Jan 11, 2025
Merged

Conversation

borisfom
Copy link
Collaborator

Back to non-lists API
Good news - it's still script-compliant, too :)

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
@borisfom borisfom requested review from mariogeiger and v0i0 January 11, 2025 06:22
@borisfom
Copy link
Collaborator Author

I am getting those unexpected failures from the backend, do those ring any bells:
E TypeError: tensor_product_uniform_1d_bwd_bwd(): incompatible function arguments. The following argument types are supported:
E 1. tensor_product_uniform_1d_bwd_bwd(num_paths: int, data: ndarray[], math_type: int, inputs: collections.abc.Sequence[ndarray[]], grad
_inputs: collections.abc.Sequence[ndarray[]], outputs: collections.abc.Sequence[ndarray[]], stream: int) -> None
E
E Invoked with types: int, torch.Tensor, int, list, list, list, int
If I roll backend back to the pip version, those go away - so it is some regression introduced since. pip version breaks on *kwargs though (that’s expected).

@borisfom borisfom merged commit 3969d2e into NVIDIA:main Jan 11, 2025
10 of 11 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants