-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Gpuciscripts clean and update #111
Conversation
[skip ci] Update master references for main branch
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
Could you edit the PR to merge into the develop branch? |
I edited it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Is this still WIP? If this is ready to be merged please remove/change |
Still WIP. gpuci_logger and parallel level changed. |
rerun tests |
1 similar comment
rerun tests |
@avolkov1 Hi. The checks are showing a flake8 error. Would you be able to take a look? |
I'm don't understand what this flake8 is being run on. In the
From above in the log the output is:
I'm not familiar with flake8 usage like that. Typically wouldn't you run flake8 on the code directory:
So I would expect it to run on the python code in the gquant subdirectory. |
@avolkov1 Thank you. You rock! |
@avolkov1 This can be merged, I don't have access to do so. |
In CI folder the following changes have been made:
Remove logger function and replace all logger calls with gpuci_logger
Removed all ellipses ... from logger messages
Prepend /opt to the conda path in PATH variable
Replace conda with gpuci_conda_retry for build and install calls (Did not replace conda activate with gpuci_conda_retry)
Replace source activate with the following:
. /opt/conda/etc/profile.d/conda.sh
conda activate rapids
Replace conda list with more verbose information:
conda info
conda config --show-sources
conda list --show-channel-urls
Update Copyright year in the top of scripts to include 2020 if applicable
Set PARALLEL_LEVEL to ${PARALLEL_LEVEL:-4}
Set gpuci_conda_retry flags in cpu/build.sh
Setup 'gpuci_conda_retry' for build retries (results in 2 total attempts)
export GPUCI_CONDA_RETRY_MAX=1
export GPUCI_CONDA_RETRY_SLEEP=30
Replace calls to gcc and g++ with $CC and $CXX respectively