Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Gpuciscripts clean and update #111

Merged
merged 9 commits into from
Dec 11, 2020
Merged

Conversation

msadang
Copy link
Contributor

@msadang msadang commented Nov 10, 2020

In CI folder the following changes have been made:

  • Remove logger function and replace all logger calls with gpuci_logger

  • Removed all ellipses ... from logger messages

  • Prepend /opt to the conda path in PATH variable

  • Replace conda with gpuci_conda_retry for build and install calls (Did not replace conda activate with gpuci_conda_retry)

  • Replace source activate with the following:
    . /opt/conda/etc/profile.d/conda.sh
    conda activate rapids

  • Replace conda list with more verbose information:
    conda info
    conda config --show-sources
    conda list --show-channel-urls

  • Update Copyright year in the top of scripts to include 2020 if applicable

  • Set PARALLEL_LEVEL to ${PARALLEL_LEVEL:-4}

  • Set gpuci_conda_retry flags in cpu/build.sh
    Setup 'gpuci_conda_retry' for build retries (results in 2 total attempts)
    export GPUCI_CONDA_RETRY_MAX=1
    export GPUCI_CONDA_RETRY_SLEEP=30

  • Replace calls to gcc and g++ with $CC and $CXX respectively

@GPUtester
Copy link

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@avolkov1 avolkov1 self-requested a review November 10, 2020 15:23
@avolkov1 avolkov1 self-assigned this Nov 10, 2020
@avolkov1
Copy link
Contributor

Could you edit the PR to merge into the develop branch?
Thanks

@yidong72 yidong72 changed the base branch from main to develop November 11, 2020 15:55
@yidong72
Copy link
Collaborator

Could you edit the PR to merge into the develop branch?
Thanks

I edited it

Copy link
Contributor

@avolkov1 avolkov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@avolkov1
Copy link
Contributor

Is this still WIP? If this is ready to be merged please remove/change [WIP] in the title.

@msadang
Copy link
Contributor Author

msadang commented Nov 13, 2020

Still WIP.

gpuci_logger and parallel level changed.

@msadang msadang changed the title [WIP] - Gpuciscripts clean and update Gpuciscripts clean and update Dec 1, 2020
@msadang
Copy link
Contributor Author

msadang commented Dec 9, 2020

rerun tests

1 similar comment
@msadang
Copy link
Contributor Author

msadang commented Dec 9, 2020

rerun tests

@msadang
Copy link
Contributor Author

msadang commented Dec 9, 2020

@avolkov1 Hi. The checks are showing a flake8 error. Would you be able to take a look?
https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/gquant/job/prb/job/gquant-style/4/console

@avolkov1
Copy link
Contributor

I'm don't understand what this flake8 is being run on. In the style.sh I see:

FLAKE=`flake8 python`

From above in the log the output is:

15:08:01   File "/opt/conda/envs/rapids/lib/python3.7/tokenize.py", line 390, in find_cookie
15:08:01     raise SyntaxError(msg)
15:08:01 SyntaxError: invalid or missing encoding declaration for '/opt/conda/envs/rapids/bin/python'
15:08:01 

15:08:01 

15:08:01 >>>> PASSED: flake8 style check

I'm not familiar with flake8 usage like that. Typically wouldn't you run flake8 on the code directory:

flake8 path/to/code/

So I would expect it to run on the python code in the gquant subdirectory.

@msadang
Copy link
Contributor Author

msadang commented Dec 11, 2020

I'm don't understand what this flake8 is being run on. In the style.sh I see:

FLAKE=`flake8 python`

From above in the log the output is:

15:08:01   File "/opt/conda/envs/rapids/lib/python3.7/tokenize.py", line 390, in find_cookie
15:08:01     raise SyntaxError(msg)
15:08:01 SyntaxError: invalid or missing encoding declaration for '/opt/conda/envs/rapids/bin/python'
15:08:01 

15:08:01 

15:08:01 >>>> PASSED: flake8 style check

I'm not familiar with flake8 usage like that. Typically wouldn't you run flake8 on the code directory:

flake8 path/to/code/

So I would expect it to run on the python code in the gquant subdirectory.

@avolkov1 Thank you. You rock!

@msadang
Copy link
Contributor Author

msadang commented Dec 11, 2020

@avolkov1 This can be merged, I don't have access to do so.

@avolkov1 avolkov1 merged commit 738d8fe into NVIDIA:develop Dec 11, 2020
@avolkov1 avolkov1 mentioned this pull request Feb 11, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants