Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[REVIEW]gquant 1.0.1 #115

Merged
merged 4 commits into from
Jan 20, 2021
Merged

[REVIEW]gquant 1.0.1 #115

merged 4 commits into from
Jan 20, 2021

Conversation

yidong72
Copy link
Collaborator

This release added 'gquant-plugin' entry point support. And it is a placeholder for gquantlab plugin for Jupyterlab2

yidong72 and others added 3 commits January 20, 2021 11:09
* added external plugin
* upgrade the build.sh jupyterlab 2 support
@yidong72 yidong72 requested a review from avolkov1 January 20, 2021 17:37
Copy link
Contributor

@avolkov1 avolkov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just clarify the version tag with or without "v".

@yidong72
Copy link
Collaborator Author

Let's make it consistent to always prepend a 'v' to the version number.

Copy link
Contributor

@avolkov1 avolkov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you.

@avolkov1 avolkov1 merged commit 2da5fea into main Jan 20, 2021
@avolkov1 avolkov1 mentioned this pull request Feb 11, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants