Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[REVIEW]fixed a bug in the split node #122

Merged
merged 1 commit into from
Feb 25, 2021
Merged

[REVIEW]fixed a bug in the split node #122

merged 1 commit into from
Feb 25, 2021

Conversation

yidong72
Copy link
Collaborator

Found a bug in the split node that needs to be fixed.

@yidong72 yidong72 requested a review from avolkov1 February 25, 2021 17:22
avolkov1
avolkov1 approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@avolkov1 avolkov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is very subtle. Not sure what bug it was causing, but looks good.

@yidong72
Copy link
Collaborator Author

The change is very subtle. Not sure what bug it was causing, but looks good.

col_from_inport is only defined inside the if condidtion. When adding a new node, the col_from_inport is not defined and it will create a "not defined' error

@avolkov1 avolkov1 merged commit e3a5e46 into main Feb 25, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@avolkov1 avolkov1 avolkov1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yidong72 @avolkov1