[REVIEW]add the dynamic input port meta check #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 1.0.4 candidate.
avolkov1
reviewed
Jun 7, 2021
There was a problem hiding this comment.
Everything looks good but I got unit tests failures for the performance test. The number of calls changing for meta setup makes sense, but I'm not sure about why the ports_setup calls changes especially the "_node_taskgraph_extension_mixin.ports_setup_ext". Could you please check and fix the unit test. The regression might have happened before we just didn't catch it.
======================================================================
FAIL: test_ports_setup_performance (tests.unit.test_performance.TestPerformance)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/avolkov/projects/gitrepos/cuquant/gQuant/plugins/gquant_plugin/tests/unit/test_performance.py", line 93, in test_ports_setup_performance
self.assertTrue(
AssertionError: False is not true : template_node_mixin.ports_setup is called 77 (expected 61) times.
======================================================================
FAIL: test_meta_setup_performance (tests.unit.test_performance.TestPerformance)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/avolkov/projects/gitrepos/cuquant/gQuant/plugins/gquant_plugin/tests/unit/test_performance.py", line 108, in test_meta_setup_performance
self.assertTrue(
AssertionError: False is not true : _node_flow.meta_setup is called 177 (expected 158) times.
======================================================================
FAIL: test_ports_setup_performance (tests.unit.test_performance.TestPerformance)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/avolkov/projects/gitrepos/cuquant/gQuant/plugins/gquant_plugin/tests/unit/test_performance.py", line 95, in test_ports_setup_performance
self.assertTrue(
AssertionError: False is not true : _node_flow.ports_setup is called 320 (expected 304) times.
======================================================================
FAIL: test_ports_setup_performance (tests.unit.test_performance.TestPerformance)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/avolkov/projects/gitrepos/cuquant/gQuant/plugins/gquant_plugin/tests/unit/test_performance.py", line 96, in test_ports_setup_performance
self.assertTrue(
AssertionError: False is not true : _node_taskgraph_extension_mixin.ports_setup_ext is called 77 (expected 61) times.
----------------------------------------------------------------------
avolkov1
approved these changes
Jun 7, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I added the dynamic input port meta data check. It is calculated based on the
self.confinformation in theself.updatemethod. Please review.