Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix #50 - Rename notebook folder to notebooks #51

Merged
merged 1 commit into from
Aug 16, 2019
Merged

Fix #50 - Rename notebook folder to notebooks #51

merged 1 commit into from
Aug 16, 2019

Conversation

miguelusque
Copy link
Contributor

Fix issue #50.

notebook folder has been renamed as notebooks.

Previously discussed with @yidong72

Copy link
Contributor

@avolkov1 avolkov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, we can rename the directory. Be careful that when you sync up with this commit if you have non-tracked files in the original notebook directory that you want to keep, this commit doesn't delete those. Maybe backup notebook dir to something (cp -r notebook notebook_bkup) prior to sync just in case.

@avolkov1 avolkov1 merged commit ae57322 into NVIDIA:develop Aug 16, 2019
@miguelusque miguelusque deleted the fix_50 branch August 16, 2019 22:09
@miguelusque miguelusque assigned miguelusque and unassigned avolkov1 Aug 19, 2019
@miguelusque miguelusque changed the title Fix 50 - Rename notebook folder to notebooks Fix #50 - Rename notebook folder to notebooks Aug 20, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants