Feature mulit assets indicator #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avolkov1
reviewed
Jul 11, 2019
There was a problem hiding this comment.
The indicate_demo.ipynb is a bit large. Cell 4 with get_figure function is massive. Can that be refactored into a factory and into a separate module? Then import from the module.
All the code looks good though. If you don't have time to fix up the notebook I'll approve and merge.
|
We can make a different issue to clean up the notebooks. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to compute features manually, I need to compute indicators for all assets.
These changes allow me to compute indicators for all assets efficiently.