[REVIEW] Add CI scripts and conda recipe #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have not tested with v0.11. Current master and development branches of gQuant should work with version 0.10. |
avolkov1
reviewed
Dec 9, 2019
There was a problem hiding this comment.
Looks good. So by merging will this enable our project on gpuCI? Are there more details or documentation explaining how the ci is triggered?
I found docs here:
https://docs.rapids.ai/maintainers/gpuci/
Do I need to setup "GitHub pull request builder plugin"?
Nope, I'll take care of the rest of the setup. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tied the version of cudf/dask-cudf to the same version of gQuant which probably isn't correct since the tags and branches do not match between the two.
@avolkov1 What version of cudf is compatible? The unit tests fail with v0.11 nightlies.