-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
CUQ-5: Mortgage example using gQuant. #9
CUQ-5: Mortgage example using gQuant. #9
Conversation
Review my current progress so far. Jupyter notebook:
modules:
scripts to run (python <script>):
TODO before ready to merge: Type checking not being handled correctly for a corner case with cudf dataframes when Finish the notebook. Add a conclusion/summary, etc. Just go over the code and add docstrings, comments, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are some little things that need to be fixed like qquant and it is better to remove those commented out code for readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will push the latest edits very soon. Been working on the various corner cases with logger in dask distributed workers when running in jupyter lab/notebook.
b94c987
to
8317304
Compare
Check category and date types for cudf dataframes. Add mortgage workflow implemented with gQuant. Finish jupyter notebook example. Use input references in workflow definition.
8317304
to
3276b57
Compare
I squashed and pushed all the latest changes. If you cloned my CUQ-5-Mortgage-Example-Using-qQuant branch, you might have to delete and re-clone. I finished the TODOs I listed for myself.
You have to be careful comparing types. Comparing a pandas dtype with numpy dtype throws a type error. Convert to common comparison type i.e. string then compare.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me now.
I am going to merge it.
Thanks! Going over the code today adding docstrings to various functions and classes, and cleaning up the logger logic a bit. I'll make another PR on another branch when I finish. |
Draft pull request for review. I still need to clean up the code and finish up the jupyter notebook. But implementation wise it's all there.