update default go version of the main container image #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
approved these changes
Aug 20, 2024
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com> As the go.mod file pins the minimum go version to 1.22.2, it no longer makes sense for the container's default go version to be a values lesser than that. Sp we bump the default golang build arg to 1.22.6
|
Thanks for the review @elezar . I have rebased the PR on top of the latest changes |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the go.mod file pins the minimum go version to 1.22.2, it no longer makes sense for the container's default go version to be a values lesser than that. Sp we bump the default golang build arg to 1.22.6
Signed-off-by: Tariq Ibrahim tibrahim@nvidia.com