Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[xgboost] Remove default parameters #226

Merged
merged 3 commits into from
Sep 7, 2022
Merged

[xgboost] Remove default parameters #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f8722d
remove the default parameters for xgboost examples
wbo4958 Aug 31, 2022
1d4c6a6
remove the default parameters
wbo4958 Aug 31, 2022
7bf8d90
remove unused variables for mortgage-ETL
wbo4958 Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions examples/XGBoost-Examples/agaricus/scala/src/com/nvidia/spark/examples/agaricus/Main.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,6 @@ object Main {
val xgbClassificationModel = if (xgboostArgs.isToTrain) {
// build XGBoost classifier
val paramMap = xgboostArgs.xgboostParams(Map(
"eta" -> 0.1,
"missing" -> 0.0,
"max_depth" -> 2,
"objective" -> "binary:logistic",
"eval_sets" -> datasets(1).map(ds => Map("eval" -> ds)).getOrElse(Map.empty)
))
Expand Down
14 changes: 0 additions & 14 deletions examples/XGBoost-Examples/mortgage/notebooks/scala/mortgage-ETL.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,20 +462,6 @@
" (labelColName, IntegerType)\n",
" )\n",
"\n",
"val commParamMap = Map(\n",
" \"eta\" -> 0.1,\n",
" \"gamma\" -> 0.1,\n",
" \"missing\" -> 0.0,\n",
" \"max_depth\" -> 10,\n",
" \"max_leaves\" -> 256,\n",
" \"objective\" -> \"binary:logistic\",\n",
" \"grow_policy\" -> \"depthwise\",\n",
" \"min_child_weight\" -> 30,\n",
" \"lambda\" -> 1,\n",
" \"scale_pos_weight\" -> 2,\n",
" \"subsample\" -> 1,\n",
" \"nthread\" -> 1,\n",
" \"num_round\" -> 100)\n",
"var cachedDictDF: DataFrame = _"
]
},
Expand Down
11 changes: 0 additions & 11 deletions ...les/XGBoost-Examples/mortgage/scala/src/com/nvidia/spark/examples/mortgage/Mortgage.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,17 +60,6 @@ private[mortgage] trait Mortgage {
lazy val featureNames = schema.filter(_.name != labelColName).map(_.name).toArray

val commParamMap = Map(
"eta" -> 0.1,
"gamma" -> 0.1,
"missing" -> 0.0,
"max_depth" -> 10,
"max_leaves" -> 256,
"objective" -> "binary:logistic",
"grow_policy" -> "depthwise",
"min_child_weight" -> 30,
"lambda" -> 1,
"scale_pos_weight" -> 2,
"subsample" -> 1,
"nthread" -> 1,
"num_round" -> 100)
}
5 changes: 1 addition & 4 deletions examples/XGBoost-Examples/taxi/scala/src/com/nvidia/spark/examples/taxi/Taxi.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,7 @@ private[taxi] trait Taxi {
lazy val featureNames = etledSchema.filter(_.name != labelColName).map(_.name).toArray

lazy val commParamMap = Map(
"learning_rate" -> 0.05,
"max_depth" -> 8,
"subsample" -> 0.8,
"gamma" -> 1
"num_round" -> 100
)

val rawSchema = StructType(Seq(
Expand Down