Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update urllib3 requirement and cleanup instructions #503

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

rishic3
Copy link
Collaborator

@rishic3 rishic3 commented Feb 25, 2025

  • Pin of urllib3<2 was an artifact from the old Databricks runtime we were using and is no longer needed. Unpinning allows the latest pytriton to be used.
  • Install libstdcxx by default since latest PyTriton requires 3.4.30
  • While testing on CSPs, cleaned up/fixed some instructions.

Signed-off-by: Rishi Chandra <rishic@nvidia.com>
@rishic3 rishic3 marked this pull request as ready for review February 25, 2025 17:43
@rishic3 rishic3 requested a review from eordentlich February 25, 2025 17:43
@rishic3 rishic3 changed the base branch from branch-25.02 to main February 26, 2025 17:22
Copy link
Collaborator

@eordentlich eordentlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rishic3 rishic3 merged commit 14e9bbc into NVIDIA:main Feb 27, 2025
2 of 3 checks passed
@rishic3 rishic3 deleted the installation-fixes branch February 27, 2025 21:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants