Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[FEA] GetJsonObject: Implement get-json-object in JNI repo as Spark does #1823

Closed
15 tasks done
res-life opened this issue Mar 4, 2024 · 5 comments
Closed
15 tasks done
Assignees

Comments

@res-life
Copy link
Collaborator

res-life commented Mar 4, 2024

Is your feature request related to a problem? Please describe.

There are some issues for the current get-json-object, refer to issues link
We plan to implement get-json-object as Spark does. Then these issues will be fixed or be easy to be fixed.

Describe the solution you'd like

  • Implement a JSON parser like Jackson does, supports ALLOW_UNESCAPED_CONTROL_CHARS and ALLOW_SINGLE_QUOTES
  • Implement a Path parser like Spark does
  • Implement utilities like Spark does
  • Implement get-json-object like Spark does

tasks

other
Totally follow Spark specific logic of get-json-object

3 follow-up issues for release 24.06
Refine doc: #1905
Address comments: #1906
Perf: #1907

@res-life res-life assigned thirtiseven and res-life and unassigned thirtiseven and res-life Mar 4, 2024
@res-life res-life changed the title [FEA] Implement get-json-object in JNI repo as Spark does [FEA] GetJsonObject: Implement get-json-object in JNI repo as Spark does Mar 5, 2024
@res-life
Copy link
Collaborator Author

get-json-object JNI repo PR posted: #1893

@res-life
Copy link
Collaborator Author

Confirmed with @thirtiseven, we do not need to revert link1,
link2, because solution changed, we now are using Java JSON Path parser. So close the last item.

@res-life
Copy link
Collaborator Author

Haoyang finished the perf test, refer to the description in PR

@res-life
Copy link
Collaborator Author

Number normalization PR: #1897

@res-life
Copy link
Collaborator Author

The last task is merging the feature branch to branch-24.04.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

4 participants