Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[FEA] [follow-up] getJsonObject: Address comments for new version of getJsonObject #1906

Closed
res-life opened this issue Mar 27, 2024 · 0 comments · Fixed by #1924
Closed

[FEA] [follow-up] getJsonObject: Address comments for new version of getJsonObject #1906

res-life opened this issue Mar 27, 2024 · 0 comments · Fixed by #1924
Assignees
@thirtiseven
Labels
feature request

Comments

@res-life
Copy link
Collaborator

This is from: #1893

Due to limited time, #1893 only focus on the correctness of new version of getJsonObject,
use this follow-up issue to refactor, including:

  • Rename enum class items to uppercase
  • Nits
  • Move Kernel code to cuh file.
  • others
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@thirtiseven thirtiseven

Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Get json object comments address thirtiseven/spark-rapids-jni
3 participants
@mattahrens @thirtiseven @res-life