Support cudf pin with rapids-cmake #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build |
jlowe
reviewed
Mar 18, 2024
There was a problem hiding this comment.
For proper attribution and to make this a bit easier to review vs. the original source, I think this PR should have been done as a cherry pick of the original reference commit to preserve the original author and then commits added to that (e.g.: fixing copyrights, adding the pinned json from the build, etc.)
So that we can get SHA Use same format of CopyRight Use cudf/rapids_config.cmake which is renamed from fetch_rapids.cmake Update versions to latest Signed-off-by: Gary Shen <gashen@nvidia.com>
GaryShen2008
force-pushed
the
add-cudf-pin
branch
from
3738649 to
9fb1832
Compare
Signed-off-by: Gary Shen <gashen@nvidia.com>
|
build |
robertmaynard
approved these changes
Mar 19, 2024
|
build |
1 similar comment
|
build |
jlowe
reviewed
Mar 20, 2024
since the second one can commit it at once Signed-off-by: Gary Shen <gashen@nvidia.com>
jlowe
approved these changes
Mar 20, 2024
|
build |
jlowe
added a commit
to jlowe/spark-rapids-jni
that referenced
this pull request
Mar 25, 2024
This reverts commit d8771da. Signed-off-by: Jason Lowe <jlowe@nvidia.com>
jlowe
added a commit
that referenced
this pull request
Mar 25, 2024
jlowe
pushed a commit
to jlowe/spark-rapids-jni
that referenced
this pull request
Mar 26, 2024
* Use rapids-cmake to pin cudf dependencies to known working SHA1's * Use git download rapids-cmake So that we can get SHA Use same format of CopyRight Use cudf/rapids_config.cmake which is renamed from fetch_rapids.cmake Update versions to latest Signed-off-by: Gary Shen <gashen@nvidia.com> * Commit cudf to the latest code before mvn verify Signed-off-by: Gary Shen <gashen@nvidia.com> * Remove the first commit of cudf since the second one can commit it at once Signed-off-by: Gary Shen <gashen@nvidia.com> --------- Signed-off-by: Gary Shen <gashen@nvidia.com> Co-authored-by: Robert Maynard <rmaynard@nvidia.com>
jlowe
added a commit
that referenced
this pull request
Apr 2, 2024
* Support cudf pin with rapids-cmake (#1877) * Use rapids-cmake to pin cudf dependencies to known working SHA1's * Use git download rapids-cmake So that we can get SHA Use same format of CopyRight Use cudf/rapids_config.cmake which is renamed from fetch_rapids.cmake Update versions to latest Signed-off-by: Gary Shen <gashen@nvidia.com> * Commit cudf to the latest code before mvn verify Signed-off-by: Gary Shen <gashen@nvidia.com> * Remove the first commit of cudf since the second one can commit it at once Signed-off-by: Gary Shen <gashen@nvidia.com> --------- Signed-off-by: Gary Shen <gashen@nvidia.com> Co-authored-by: Robert Maynard <rmaynard@nvidia.com> * Update cudf pin versions Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Update pin versions Signed-off-by: Jason Lowe <jlowe@nvidia.com> --------- Signed-off-by: Gary Shen <gashen@nvidia.com> Signed-off-by: Jason Lowe <jlowe@nvidia.com> Co-authored-by: Gary Shen <gashen@nvidia.com> Co-authored-by: Robert Maynard <rmaynard@nvidia.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1666
Main code is copied from robertmaynard@85f5a29