Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix tests failures in dpp_test.py #11023

Closed
Tracked by #11004
razajafri opened this issue Jun 8, 2024 · 2 comments · Fixed by #11097
Closed
Tracked by #11004

Fix tests failures in dpp_test.py #11023

razajafri opened this issue Jun 8, 2024 · 2 comments · Fixed by #11097
Assignees
@mythrocks
Labels
bug Something isn't working Spark 4.0+ Spark 4.0+ issues

Comments

@razajafri
Copy link
Collaborator 

FAILED ../../../../integration_tests/src/main/python/dpp_test.py::test_dpp_bypass
FAILED ../../../../integration_tests/src/main/python/dpp_test.py::test_dpp_empty_relation
FAILED ../../../../integration_tests/src/main/python/dpp_test.py::test_dpp_from_swizzled_hash_keys
FAILED ../../../../integration_tests/src/main/python/dpp_test.py::test_dpp_reuse_broadcast_exchange
FAILED ../../../../integration_tests/src/main/python/dpp_test.py::test_dpp_reuse_broadcast_exchange_cpu_scan
FAILED ../../../../integration_tests/src/main/python/dpp_test.py::test_dpp_skip
FAILED ../../../../integration_tests/src/main/python/dpp_test.py::test_dpp_via_aggregate_subquery
@razajafri razajafri added bug Something isn't working ? - Needs Triage Need team to review and classify labels Jun 8, 2024
@razajafri razajafri mentioned this issue Jun 8, 2024
Open
@razajafri razajafri added the Spark 4.0+ Spark 4.0+ issues label Jun 8, 2024
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Jun 11, 2024
@mythrocks mythrocks self-assigned this Jun 12, 2024
@mythrocks
Copy link
Collaborator

All these tests run when ANSI=off, but there are memory leaks:

../../../../integration_tests/src/main/python/dpp_test.py::test_dpp_reuse_broadcast_exchange[false-4-parquet][DATAGEN_SEED_OVERRIDE=0, TZ=UTC, INJECT_OOM, IGNORE_ORDER] 2
024-06-12 21:43:40,169 [Cleaner Thread] ERROR ai.rapids.cudf.HostMemoryBuffer - A HOST BUFFER WAS LEAKED (ID: 10873 777018745920)
2024-06-12 21:43:40,169 [Cleaner Thread] ERROR ai.rapids.cudf.HostMemoryBuffer - A HOST BUFFER WAS LEAKED (ID: 10744 77700dec6730)
2024-06-12 21:43:40,170 [Cleaner Thread] ERROR ai.rapids.cudf.HostMemoryBuffer - A HOST BUFFER WAS LEAKED (ID: 10871 77701cdff130)
2024-06-12 21:43:40,170 [Cleaner Thread] ERROR ai.rapids.cudf.HostMemoryBuffer - A HOST BUFFER WAS LEAKED (ID: 11822 77700df0a560)
2024-06-12 21:43:40,170 [Cleaner Thread] ERROR ai.rapids.cudf.HostMemoryBuffer - A HOST BUFFER WAS LEAKED (ID: 11541 777013e78520)
2024-06-12 21:43:40,170 [Cleaner Thread] ERROR ai.rapids.cudf.HostMemoryBuffer - A HOST BUFFER WAS LEAKED (ID: 11792 77701ce20ef0)

mythrocks added a commit to mythrocks/spark-rapids that referenced this issue Jun 25, 2024
@mythrocks
Prep miscellaneous integ tests for Spark 4
9316347 
Fixes NVIDIA#11020. (grouping_sets_test.py)
Fixes NVIDIA#11023. (dpp_test.py)
Fixes NVIDIA#11025. (date_time_test.py)
Fixes NVIDIA#11026. (map_test.py)

This commit prepares miscellaneous integration tests to be run on Spark
4.

Certain integration tests fail on Spark 4 because of ANSI mode being
enabled by default.  This commit disables ANSI on the failing tests, or
introduces other fixes so that the tests may pass correctly.

Signed-off-by: MithunR <mithunr@nvidia.com>
@mythrocks mythrocks mentioned this issue Jun 25, 2024
Merged
@razajafri
Copy link
Collaborator Author

Do we have memory leaks with Spark versions below 4?

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@mythrocks mythrocks

Labels
bug Something isn't working Spark 4.0+ Spark 4.0+ issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix miscellaneous integ tests for Spark 4 [databricks] mythrocks/spark-rapids
3 participants
@mattahrens @mythrocks @razajafri