Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[FEA] Support Decimal Casts #1330

Closed
revans2 opened this issue Dec 8, 2020 · 2 comments · Fixed by #1438
Closed

[FEA] Support Decimal Casts #1330

revans2 opened this issue Dec 8, 2020 · 2 comments · Fixed by #1438
Assignees
@sperlingxx
Labels
feature request New feature or request

Comments

@revans2
Copy link
Collaborator

revans2 commented Dec 8, 2020

Is your feature request related to a problem? Please describe.
Cudf supports casting decimal to/from double, float, int, long, etc. We should support these too. We need to be careful to test double/float especially because there can be round off issues that we need to test to see if they are correct.
@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify labels Dec 8, 2020
@revans2 revans2 mentioned this issue Dec 8, 2020
Closed
27 tasks
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Dec 15, 2020
@sameerz
Copy link
Collaborator

sameerz commented Dec 16, 2020

Tagging @sperlingxx on this issue.

@sameerz sameerz mentioned this issue Jan 6, 2021
Closed
@sameerz sameerz linked a pull request Jan 7, 2021 that will close this issue
Cast from numeric types to decimal type #1438
Merged
@sameerz
Copy link
Collaborator

sameerz commented Jan 8, 2021

PR #1438 addresses casting with the exception of decimal to decimal casts, we need one more PR to address decimal to decimal casting.

@sperlingxx sperlingxx mentioned this issue Jan 15, 2021
Merged
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
@pxLi
Update cudf submodule to released tag v23.08.00 (NVIDIA#1330)
e2e4f0a 
Signed-off-by: Peixin Li <pxli@nyu.edu>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@sperlingxx sperlingxx

Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cast from numeric types to decimal type sperlingxx/spark-rapids
3 participants
@revans2 @sperlingxx @sameerz