Fix array_transform to not recompute the argument #10015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
|
build |
1 similar comment
|
build |
razajafri
previously approved these changes
Dec 11, 2023
Comment on lines
232
to
238
| val explodedTable = withResource(GpuProjectExec.project(inputBatch, boundIntermediate)) { | ||
| intermediateBatch => | ||
| withResource(GpuColumnVector.combineColumns(intermediateBatch, argColumn)) { | ||
| projectedBatch => | ||
| withResource(GpuColumnVector.from(projectedBatch)) { projectedTable => | ||
| projectedTable.explodePosition(boundIntermediate.length) | ||
| } |
There was a problem hiding this comment.
nit: could this and should this be refactored to a private method? It can be reused by passing the method to run explodePosition or explode
jlowe
previously approved these changes
Dec 11, 2023
| @@ -895,6 +895,22 @@ public static ColumnarBatch combineColumns(ColumnarBatch ... batches) { | |||
| return incRefCounts(ret); | |||
| } | |||
|
|
|||
| public static ColumnarBatch combineColumns(ColumnarBatch cb, GpuColumnVector ... vectors) { | |||
| final int numRows = cb.numRows(); | |||
| ArrayList<ColumnVector> columns = new ArrayList<>(); | |||
There was a problem hiding this comment.
Nit: We know exactly how big the array needs to be and can hint this here.
Suggested change
| ArrayList<ColumnVector> columns = new ArrayList<>(); | |
| ArrayList<ColumnVector> columns = new ArrayList<>(cb.numCols() + vectors.length); |
|
build |
|
@razajafri and @jlowe please take another look |
jlowe
approved these changes
Dec 11, 2023
razajafri
approved these changes
Dec 12, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #9472
Thanks to @razajafri for doing the majority of the debugging on this.