Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Defined Shims Should Be Declared In POM #10167

Merged
merged 5 commits into from
Jan 10, 2024

Conversation

razajafri
Copy link
Collaborator

@razajafri razajafri commented Jan 9, 2024

This PR makes sure that all buildvers referenced in spark-rapids-shim-json-lines in the Scala source comments
are included in all.buildvers property in the pom.xml

fixes #10166

@razajafri razajafri requested a review from gerashegalov January 9, 2024 00:09
@razajafri razajafri changed the title check shim exists in all.buildversions Defined Shims Should Be Declared In POM Jan 9, 2024
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
@razajafri razajafri added the bug Something isn't working label Jan 9, 2024
@razajafri
Copy link
Collaborator Author

@gerashegalov PTAL

gerashegalov
gerashegalov previously approved these changes Jan 9, 2024
Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@razajafri
Copy link
Collaborator Author

build

Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@razajafri razajafri merged commit dfc1d97 into NVIDIA:branch-24.02 Jan 10, 2024
@razajafri razajafri deleted the undeclared-shim branch January 10, 2024 06:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect Undeclared Shim in POM.xml
3 participants