Disable GetJsonObject by default and add tests for as many issues with it as possible #10220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h it as possible Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
jlowe
reviewed
Jan 18, 2024
|
build |
jlowe
approved these changes
Jan 19, 2024
|
build |
|
This has crashed the precommit build twice with the same error about the integration tests crashing. I need to do dig some more before we try and build again. |
|
Never mind it is the bind error for the UI again. |
|
build |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes #10197 and adds tests for a large number of other issues.