Add tryAcquire to GpuSemaphore #10330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revans2
requested review from
jlowe,
tgravescs,
GaryShen2008,
NvTimLiu and
gerashegalov
as code owners
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
revans2
force-pushed
the
GpuSem_try_acquire
branch
from
61b36d9 to
337e060
Compare
|
build |
| @@ -245,6 +259,30 @@ private final class SemaphoreTaskInfo() extends Logging { | |||
| } | |||
| } | |||
|
|
|||
| def tryAcquire(semaphore: Semaphore): Boolean = synchronized { | |||
There was a problem hiding this comment.
Do you think there are some smarter heuristics to be had if we return the number of waiters when the semaphore cannot be acquired via Either[Int,Boolean] ?
jlowe
reviewed
Jan 30, 2024
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuSemaphore.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuSemaphore.scala
Outdated
Show resolved
Hide resolved
|
build |
|
@jlowe and @gerashegalov please take another look |
jlowe
approved these changes
Jan 30, 2024
sperlingxx
pushed a commit
to sperlingxx/spark-rapids
that referenced
this pull request
Feb 2, 2024
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #10261