Distinct inner join #10503
Merged
Distinct inner join #10503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
jlowe
added
performance
|
build |
|
build |
Merged
revans2
approved these changes
Mar 4, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on rapidsai/cudf#15019.
Updates the inner hash join code to leverage the cudf distinct join API where the join can be performed much more quickly when it is known there are no duplicated join keys in the hash table. Since we're already doing a groupby on the build-side keys to estimate the explosiveness of a join, we already know when the hash table is using unique keys.
Running this on NDS at scale factor 3k resulted in a 2% overall improvement with the following statistically-significant (p-value < 0.05) changes at the individual query level: