Try to make degenerative joins here impossible for these tests [databricks] #10551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Navin Kumar <navink@nvidia.com>
|
build |
This was
linked to
issues
Mar 5, 2024
jlowe
previously approved these changes
Mar 5, 2024
| statement = _statements[s_index].format(fact_table, dim_table, filter_val) | ||
| filter_val, ex_key_val = create_dim_table(dim_table, store_format, length=2000) | ||
| statement = _statements[s_index].format(fact_table, dim_table, filter_val, ex_key_val) | ||
| print(filter_val, ex_key_val) |
There was a problem hiding this comment.
debug code left here by accident?
Signed-off-by: Navin Kumar <navink@nvidia.com>
jlowe
approved these changes
Mar 5, 2024
|
build |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10147 and fixes #10548.
This should fix the test failures for DPP when AQE is enabled and optimizes out joins that result in empty relations. First, it uses a randomly generated filter value used for all rows that prevents the filter predicate from failing, and also ensures that the ex_key predicate always uses a value that exists in the table.