Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Delta Lake truncation of min/max string values [databricks] #11335

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

jlowe
Copy link
Contributor

@jlowe jlowe commented Aug 15, 2024

This pulls in the changes from delta-io/delta#3430 to fix incorrect truncation of strings in Delta log statistics. Since this does not match the behavior of the CPU on most Delta Lake versions we support, the test was updated to use canned values and check the GPU statistics for what is expected when those values are truncated.

Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@jlowe jlowe added the bug Something isn't working label Aug 15, 2024
@jlowe jlowe self-assigned this Aug 15, 2024
@jlowe
Copy link
Contributor Author

jlowe commented Aug 15, 2024

build

@jlowe jlowe changed the title Fix Delta Lake truncation of min/max string values Fix Delta Lake truncation of min/max string values [databricks] Aug 15, 2024
@jlowe
Copy link
Contributor Author

jlowe commented Aug 15, 2024

build

@liurenjie1024 liurenjie1024 self-requested a review August 16, 2024 00:39
@pxLi
Copy link
Collaborator

pxLi commented Aug 16, 2024

failed #8418 in CI. going to re-kick

@pxLi
Copy link
Collaborator

pxLi commented Aug 16, 2024

build

@pxLi pxLi merged commit b043cf6 into NVIDIA:branch-24.08 Aug 16, 2024
43 of 44 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants