Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Tests to JSON Tuples #12180

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

warrickhe
Copy link
Contributor

This PR adds tests as specified in #10405.
Specifically, the cases addressed are: dictionary of ints, \r\n whitespace in strings, and garbage at the end of input lines (e.g. '{"a":100} this is valid according to spark').

Signed-off-by: Warrick He <warrickh@nvidia.com>
@jihoonson
Copy link
Collaborator

build

Copy link
Collaborator

@jihoonson jihoonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @warrickhe.

@jihoonson jihoonson merged commit cca7af7 into NVIDIA:branch-25.04 Feb 20, 2025
52 checks passed
@warrickhe warrickhe deleted the new-jsontuple-tests branch February 20, 2025 18:58
@sameerz sameerz added the test Only impacts tests label Feb 22, 2025
@warrickhe warrickhe mentioned this pull request Mar 3, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants