Not publishing integration_tests jar to Maven Central [skip ci] #4365
Conversation
Stop publishing the integration tests jar to Maven Central. Remove the aggregator dependency in the integration_tests module pom.xml. Signed-off-by: Tim Liu <timl@nvidia.com>
NvTimLiu
requested review from
gerashegalov,
tgravescs,
pxLi,
res-life,
GaryShen2008 and
Salonijain27
|
build |
|
I thought aggregator jar was needed here because we picked up internal classes. This PR doesn't change that so that changed somewhere else? I guess we will see if it builds |
It likely will because the aggregator jar will still be picked up transitively by other dependencies (e.g.: the tests module dependency) during the test build. |
Signed-off-by: Tim Liu <timl@nvidia.com>
NvTimLiu
changed the title
|
Only updated the public release script, skip ci |
|
build |
|
so what are our IT jobs going to do use to test the staging jars? I thought part of the reason we are pushing the IT tests was so we could have jobs that tested them without having to do a build. Whatever it is we need a follow on to make sure that is implemented. Unless of course we aren't testing the staging jars, which I would argue is an issue. |
|
We can deploy the IT jar to internal maven repo to be used for testing. |
|
ok, do we need to update any jobs for that or are they not setup to pull from staging anyway? |
Yes, Tim will help to change the deploy script and the related test jobs. |
Fix issue: #3934
Stop publishing the integration tests jar to Maven Central.
Remove the aggregator dependency in the integration_tests module pom.xml.
Signed-off-by: Tim Liu timl@nvidia.com