Avoid replacing a hash join if build side is unsupported by the join type #4463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type Signed-off-by: Jason Lowe <jlowe@nvidia.com>
|
build |
tgravescs
approved these changes
Jan 5, 2022
|
Odd, looks like it failed to start the CI job for some reason. Trying again. |
|
build |
jbrennan333
approved these changes
Jan 5, 2022
sameerz
added
the
task
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a sanity check to the hash join tagging to ensure that we never try to replace a hash join where the build side matches the join side. Such join setups do not directly support batching the non-build side and concatenating the results as equivalent to a single batch join.