-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add preliminary test and test framework changes for ExistanceJoin #4697
Add preliminary test and test framework changes for ExistanceJoin #4697
Conversation
Allow matching short TreeNode string against a regex. Enables to make sure that the test exhibits ExistenceJoin Contributes to NVIDIA#589 Signed-off-by: Gera Shegalov <gera@apache.org>
Signed-off-by: Gera Shegalov <gera@apache.org>
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine. I am just a little confused why this needs to be split off from the rest of the ExistanceJoin code. I guess adding in the regular expression check is technically unrelated, but then I would prefer to see that as a separate PR without the xfail test.
If I saw "Add an xfail'd test for ExistenceJoin" in the changelog I would be confused and not know why we did that or what it was all about.
It does not have to, but I thought I create it as a tiny milestone in the test-first approach. I can keep working on this branch until the feature is done and there is no need for xfail.
I will make it more clear if we are going to keep the test-only PR |
build |
Contributes to #589
Signed-off-by: Gera Shegalov gera@apache.org