Speed up copying decimal column from parquet buffer to GPU buffer #4872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
|
build |
1 similar comment
|
build |
jlowe
reviewed
Feb 25, 2022
sql-plugin/src/main/java/com/nvidia/spark/rapids/ColumnarCopyHelper.java
Outdated
Show resolved
Hide resolved
jlowe
previously approved these changes
Feb 28, 2022
revans2
reviewed
Feb 28, 2022
| import ai.rapids.cudf.HostColumnVectorCore; | ||
| import org.apache.hadoop.hive.ql.exec.vector.DecimalColumnVector; | ||
| import org.apache.spark.sql.execution.datasources.orc.OrcAtomicColumnVector; | ||
| import org.apache.spark.sql.execution.datasources.orc.OrcColumnVector; |
There was a problem hiding this comment.
nit: I don't think that the ORC columns are used and should probably be removed.
There was a problem hiding this comment.
Yes, I fixed it.
|
build |
1 similar comment
|
build |
|
build |
firestarman
approved these changes
Mar 7, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sperlingxx lovedreamf@gmail.com
Closes #4784
Adds specialized support for the columnar copy of
WritableColumnVectoron decimal type. The new implementation copies the unscaled values directly to avoid the round trip of Decimal encoding/decoding.