GpuCast.hasSideEffects now checks to see if the child expression has side-effects #5127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…side effects Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
changed the title
andygrove
changed the title
jlowe
approved these changes
Apr 1, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuCast.scala
Outdated
Show resolved
Hide resolved
jlowe
previously approved these changes
Apr 1, 2022
|
build |
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
|
build |
jlowe
previously approved these changes
Apr 1, 2022
jlowe
approved these changes
Apr 1, 2022
|
build |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andy Grove andygrove@nvidia.com
Closes #5125
When expressions with side-effects were wrapped in a CAST then we treated them as though they did not have side-effects because the
GpuCast.hasSideEffectsmethod was not checking whether the child expression had side-effects.