-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Include dependency of common jar in tools jar #5270
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cec1b7d.
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
tgravescs
reviewed
Apr 18, 2022
build |
tgravescs
reviewed
Apr 18, 2022
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
…ols_gen_reduced_pom
build |
1 similar comment
build |
jlowe
reviewed
Apr 19, 2022
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
build |
jlowe
previously approved these changes
Apr 19, 2022
tgravescs
previously approved these changes
Apr 19, 2022
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
build |
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
build |
NvTimLiu
previously approved these changes
Apr 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, +1
Dependency tree check PASS
[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ rapids-4-spark-tools_2.12 --- [INFO] com.nvidia:rapids-4-spark-tools_2.12:jar:22.06.0-SNAPSHOT
|
jlowe
previously approved these changes
Apr 20, 2022
tgravescs
reviewed
Apr 20, 2022
…ols_gen_reduced_pom
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
build |
tgravescs
approved these changes
Apr 20, 2022
Thanks @jlowe , @NvTimLiu and @tgravescs for the review. Merging this PR. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5238 .
This PR reverts #5239 where we copied ThreadFactory class in the tools module and removed the dependency on common jar.
In this PR, we added back the dependency on common jar, included only the classes needed from common jar via shade plugin and are deploying the dependency-reduced-pom.xml.
Verified by locally deploying the jar and running
mvn dependency:get