Support array_repeat #5293
Merged
Support array_repeat #5293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttnghia
reviewed
Apr 21, 2022
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/collectionOperations.scala
Show resolved
Hide resolved
ttnghia
reviewed
Apr 21, 2022
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/collectionOperations.scala
Show resolved
Hide resolved
jlowe
reviewed
Apr 21, 2022
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/collectionOperations.scala
Show resolved
Hide resolved
| } | ||
| } | ||
| // Step 3. generate list offsets from refined counts | ||
| val offsets = withResource(refinedCount) { cnt => |
There was a problem hiding this comment.
Speaking of "what if something throws?", repeated is unprotected here -- if computing the offsets causes an exception we don't close it here.
There was a problem hiding this comment.
Yes, I added the missing the closeOnEx wrapper for repeated
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/collectionOperations.scala
Show resolved
Hide resolved
revans2
reviewed
Apr 25, 2022
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/collectionOperations.scala
Outdated
Show resolved
Hide resolved
|
build |
|
build |
revans2
approved these changes
Apr 28, 2022
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/collectionOperations.scala
Show resolved
Hide resolved
|
build |
1 similar comment
|
build |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sperlingxx lovedreamf@gmail.com
Closes #5226
This PR is to support array_repeat, which relies on unmerged cuDF PR(rapidsai/cudf#10683).
The primary issue of
array_repeatis to workaround the null and negative count values, which are supported by Spark but invalid in cuDF repeat.