Enable some repetitions for \A and \Z
#5349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Navin Kumar <navink@nvidia.com>
Signed-off-by: Navin Kumar <navink@nvidia.com>
Signed-off-by: Navin Kumar <navink@nvidia.com>
…able_cap_a_z_repetitions
…able_cap_a_z_repetitions
Signed-off-by: Navin Kumar <navink@nvidia.com>
Signed-off-by: Navin Kumar <navink@nvidia.com>
|
build |
andygrove
reviewed
May 3, 2022
Comment on lines
+865
to
+866
| case (RegexEscaped('A'), '+') | | ||
| (RegexSequence(ListBuffer(RegexEscaped('A'))), '+') => |
There was a problem hiding this comment.
This pattern is repeated a few times. I wonder if it is worth introducing a utility function that can simply expressions to remove redundant list buffers?
andygrove
approved these changes
May 3, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4800 (which was also partially fixed by PR#5319 when
\Zwas finally re-enabled).This enables using
\Aand\Zin some repetition sequences to add more full support for those escape sequences in regular expressions on the GPU. This enables:+near\Aor\Z{n}or{n,}or{n,m}wheren > 0NOTE:
\A*and\A{...}can be transpiled to\A?; however cuDF does not yet support\A?, so this*and?and{0,}will all still fallback to CPU.