Fix databrick Shim to support Ansi mode when casting from string to date [databricks] #5494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chong Gao <res_life@163.com>
|
build |
|
Deadlock with #5484 |
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
|
build |
|
I cherry-picked #5484 PR to make the pre-merge pass. |
tgravescs
reviewed
May 16, 2022
| @@ -83,15 +83,36 @@ def test_cast_string_date_valid_format(): | |||
| ] | |||
| values_string_to_data = invalid_values_string_to_date + valid_values_string_to_date | |||
|
|
|||
| # test Spark Spark versions < 3.2.0, ANSI mode | |||
| @pytest.mark.skipif(not is_before_spark_320(), reason="ansi cast(string as date) throws exception only in 3.2.0+") | |||
| # Spark 320+ and db312+ support Ansi mode when casting string to date | |||
There was a problem hiding this comment.
nit 312db instead of db312
tgravescs
reviewed
May 16, 2022
|
|
||
| # test db312+, ANSI mode, valid values | ||
| @pytest.mark.skipif(not is_databricks91_or_later(), reason="Spark versions(< 320) not support Ansi mode when casting string to date") | ||
| def test_cast_string_date_valid_ansi_dbs(): |
There was a problem hiding this comment.
nit, instead of dbs put databricks since here if just looking at the test name dbs might get confused with like database
|
build |
|
build |
pxLi
approved these changes
May 17, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5482
Fixes #5481
Db312supports Ansi casting from string to data unlikeSpark312See this comment: #5482 (comment)
Signed-off-by: Chong Gao res_life@163.com