Disable 340 for premerge and nightly #5689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
firestarman
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008,
NvTimLiu and
zhanga5
as code owners
|
build |
GaryShen2008
approved these changes
May 30, 2022
firestarman
added a commit
to firestarman/spark-rapids
that referenced
this pull request
Jun 2, 2022
This reverts commit 4769926.
HaoYang670
pushed a commit
to HaoYang670/spark-rapids
that referenced
this pull request
Jun 6, 2022
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
firestarman
added a commit
to firestarman/spark-rapids
that referenced
this pull request
Jun 6, 2022
This reverts commit 4769926.
tgravescs
pushed a commit
that referenced
this pull request
Jun 13, 2022
* Remove AnsiCast for 340 Signed-off-by: Firestarman <firestarmanllc@gmail.com> * Revert "Disable 340 for premerge and nightly (#5689)" This reverts commit 4769926. * Disable the failing tests Signed-off-by: Firestarman <firestarmanllc@gmail.com> * Fix a new build error about parquet column Signed-off-by: Firestarman <firestarmanllc@gmail.com> * Add comment for the disabled tests Signed-off-by: Firestarman <firestarmanllc@gmail.com> * address comments Signed-off-by: Firestarman <firestarmanllc@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spark 340 has removed the
AnsiCastby apache/spark@5f0bae7, which will probably lead to much work in plugin.So disable 340 for premerge and nightly temporarily. But need to add it back when the issue #5688 is fixed.