Remove the ORC encryption tests [databricks] #5737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
… 3.1.x Signed-off-by: Raza Jafri <rjafri@nvidia.com>
razajafri
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008,
NvTimLiu and
zhanga5
as code owners
tgravescs
changed the title
|
please put a description of changes made and why |
|
build |
tgravescs
reviewed
Jun 3, 2022
| frame => | ||
| // ORC encryption is only allowed in 3.2+ | ||
| val isValidTestForSparkVersion = SparkShimImpl.getSparkShimVersion match { | ||
| case SparkShimVersion(major, minor, _) => major == 3 && minor != 1 |
There was a problem hiding this comment.
we don't need these checks if this is in a 320+ directory right?
There was a problem hiding this comment.
Yes, we don't. I am being defensive here in case someone moves things around. If this is an issue, I can remove them
|
Build failure is due to #5744 |
|
build |
tgravescs
requested changes
Jun 6, 2022
| withCpuSparkSession(session => { | ||
| val conf = session.sessionState.newHadoopConf() | ||
| val provider = HadoopShimsFactory.get.getHadoopKeyProvider(conf, new Random) | ||
| assume(!provider.getKeyNames.isEmpty, |
There was a problem hiding this comment.
this isn't testing anything the way its written, we need a different way to test
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
razajafri
changed the title
tgravescs
changed the title
tgravescs
approved these changes
Jun 6, 2022
|
|
build |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the ORC encryption test
There will be a follow-on PR for adding tests
fixes #5733
Signed-off-by: Raza Jafri rjafri@nvidia.com