Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding AUTO native parquet support and legacy tests #5983

Merged
merged 7 commits into from
Jul 19, 2022

Conversation

revans2
Copy link
Collaborator

@revans2 revans2 commented Jul 11, 2022

revans2 added 2 commits July 11, 2022 08:56
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
@revans2 revans2 added the task Work required that improves the product but is not user facing label Jul 11, 2022
@revans2 revans2 added this to the Jul 11 - Jul 22 milestone Jul 11, 2022
@revans2 revans2 self-assigned this Jul 11, 2022
@revans2 revans2 marked this pull request as ready for review July 19, 2022 13:56
@revans2
Copy link
Collaborator Author

revans2 commented Jul 19, 2022

build

@revans2
Copy link
Collaborator Author

revans2 commented Jul 19, 2022

@jlowe All of the dependencies are in and I think I have addressed all of your concerns. Please take another look.

Copy link
Collaborator

@abellina abellina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had minor nits on the node calculation, otherwise LGTM

@revans2
Copy link
Collaborator Author

revans2 commented Jul 19, 2022

build

@revans2
Copy link
Collaborator Author

revans2 commented Jul 19, 2022

@abellina I think I have addressed your concerns. Please take another look.

@revans2 revans2 merged commit d986513 into NVIDIA:branch-22.08 Jul 19, 2022
@revans2 revans2 deleted the better_native_parquet branch July 19, 2022 17:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
task Work required that improves the product but is not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants