Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Re-enable "transpile complex regex 2" scala test #6027

Conversation

anthony-chang
Copy link
Contributor

Closes #5656

The test "transpile complex regex 2" was disabled since we didn't allow ? adjacent to \z. I've enabled this test and just added a wildcard . between the two.

Signed-off-by: Anthony Chang antchang@nvidia.com

Signed-off-by: Anthony Chang <antchang@nvidia.com>
@anthony-chang
Copy link
Contributor Author

build

@anthony-chang anthony-chang self-assigned this Jul 19, 2022
Copy link
Collaborator

@razajafri razajafri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but would like someone else to look at it as well

@anthony-chang anthony-chang requested a review from NVnavkumar July 19, 2022 18:41
@sameerz sameerz added the test Only impacts tests label Jul 20, 2022
@tgravescs
Copy link
Collaborator

build

@anthony-chang anthony-chang merged commit 8c1b555 into NVIDIA:branch-22.08 Jul 29, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Re-instate "transpile complex regex 2" test in some form
4 participants