Fix test hang caused by parquet hadoop test jar log4j file #6049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jar Signed-off-by: Thomas Graves <tgraves@nvidia.com>
|
build |
jlowe
approved these changes
Jul 22, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6017
The issue here is that the parquet-hadoop-1.X-tests.jar contains a log4j.properties file that was being picked up by the executors. It has debug turned on and causes a ton of logging. This might be a bit hacky but just remove the log4j.properties file from the parquet hadoop test jar before we run the tests. This seems the most straight forward thing without having to create our own shims for the test jar. Open to other ideas if people have them.
Also fixes an issue with the comparison where it wasn't actually running the encryption test when it should be. The check was missing the $ in the variable name.
tested on standalone 3.2.2 and 3.3 and in local mode.
Signed-off-by: Thomas Graves tgraves@nvidia.com