Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add SQL table to Qualification's app-details view [skip ci] #6125

Merged
merged 2 commits into from
Jul 28, 2022

Conversation

amahussein
Copy link
Collaborator

@amahussein amahussein commented Jul 27, 2022

Signed-off-by: Ahmed Hussein (amahussein) a@ahussein.me

closes #6059

Features Added

  • Adds a new report summary for the SQL queriessql-recommendation.html.
    • Users can access the new report by clicking on "Per-SQL Data" link in the navigation menu.
    • Users opening the new HTML can see a combined list of all the queries and their estimated GPU performance and recommendation.
    • Users can filter by App-ID to find the queries of specific App-ID
    • Users can filter by GPU recommendation.
    • Users can search by SQL-Id, SQL-Description, or App-ID
  • Inside App-detail-view, a new table is added at the bottom to summarize the estimated GPU performance of the App queries. This table is identical to the sql-recommendation.html except that it does not show the app-ID.
  • When the --per-sql option is disabled, the table will display No Data to display in the table
  • Note that by default, all SQL tables are ordered by recomendation.desc, speedup-factor.desc, app_id.asc, and sql_id.asc
  • Updated the documentation

Changes

  • This PR does not change the core plugin code. All changes are in HTML, *.js, and *.md files
  • Updated the screenshots in the documentation. the new screenshot shows the newly added links.

ScreenShot from index.html

qualification-tool-recommendation-indexview-with-persql

ScreenShot from sql-recommendation.html

Screen Shot 2022-07-27 at 4 17 21 PM

ScreenShot from application.html
Screen Shot 2022-07-27 at 4 14 59 PM

Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
@amahussein amahussein added this to the July 22 - Aug 5 milestone Jul 27, 2022
@amahussein amahussein self-assigned this Jul 27, 2022
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
@amahussein
Copy link
Collaborator Author

build

@amahussein amahussein merged commit e0a7cd2 into NVIDIA:branch-22.08 Jul 28, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Add SQL table to Qualification's app-details view
3 participants